Use Web Cache API for extra layer of resources caching #5379
+173
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
changed the title
|
cc: @terrakok when you are back :) I'd like to include this into 1.10 |
terrakok
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Instead of the new ResourceReader's method I'd like to have next:
- CvrWebCache - implementation of the web cache specifically for CVR files
- in the web ResourceReader.readPart function implementation to add a logic: if the path is ended with
.cvrthen to use cached values
WDYT?
| import org.w3c.workers.Cache | ||
|
|
||
| /** | ||
| * We use [Cache] and [org.w3c.dom.WindowSessionStorage] APIs to cache the successful strings.cvr responses. |
There was a problem hiding this comment.
If we use it specifically for Strings.CVR then let's rename it to StringsWebCache. Otherwise, we mustn't mention cvr in the kdoc
There was a problem hiding this comment.
Now it's called ResourceWebCache. It's applied for all requests which go through web resource reader (in readAsBlob).
|
Might be worth to use it for all resource types |
|
Hi any progress? Would be nice to have for all resource types btw! |
eymar
force-pushed
the
ok/use_web_caches_for_string_resources_response
branch
from
7086016 to
c2dbca8
Compare
eymar
changed the title
|
Ready for a new review. |
terrakok
reviewed
Oct 16, 2025
terrakok
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Web Cache API for all resources
The Cache is reset on every app launch (page refresh).
The initial idea was to reset the Cache only when a new session starts, but we risk to have an outdated resources state (it can be incompatible with the app logic expectations and lead to crashes).
Fixes https://youtrack.jetbrains.com/issue/CMP-7996
Testing
This should be tested by QA
Release Notes
Fixes - Resources